Pump Version python to 3.12, 3.13. Allow pip install for python 3.12, 3.13 #210

maycuatroi · 2024-10-08T12:32:57Z

Overview

Update file pyproject.toml to enable pip install for python 3.12

References

Example workbook work perfect when I pip install on python 3.12

google-cla · 2024-10-08T12:33:02Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

maycuatroi · 2024-10-08T17:37:18Z

It's strange, I didn't make any changes to the Python code, yet it's causing CI errors with mypy.
@odashi-san, Do you think I should fix these CI errors?

odashi · 2024-10-09T09:30:37Z

@maycuatroi
It looks the errors occurred around obsolete syntax rules that the new version of mypy (after 1.9) removed its support.
For now, we can set mypy version to up to 1.8 to bypass the error, though it's better to remove obsolete code entirely from latexify.

- Improve CI libraries

maycuatroi · 2024-10-09T12:24:26Z

@odashi -san. I fixed CI to the last version of mypy and black. Please approve the CI scan

odashi · 2024-10-09T14:59:25Z

@maycuatroi Thanks!

I think you tweaked some code blocked by version switches, e.g.,

if blocks conditioned by if sys.version_info.minor < blah:
test blocks conditioned by @test_utils.require_at_most(blah)

These blocks are activated while the library is running on a conditioned version of Python, and the code block must follow the correct syntax on the corresponding version.

I guessed that this is a good time to drop support for legacy (EOL-ed) versions such as 3.7 and 3.8, by simply removing corresponding blocks from the library.
Sorry for bothering, but I'd quite appreciated it if you could take some additional efforts.

- Remove ORL python 3.8, 3.9 - Fix CI unit-test

maycuatroi · 2024-10-09T17:20:31Z

@odashi -san
I've checked and fixed the unit tests for the CI accordingly. Here's what I did:

Removed support for Python 3.7 and 3.8 (since they've reached end-of-life).
Tested with Python 3.13 – everything worked great!

I really enjoy using this library, and I appreciate your professionalism.

To ensure everything works across multiple Python versions, I also created a custom Docker Compose setup for running the CI tests on various versions 😄 (I'm not commit it yet):

version: "3.8"

services:
  unit-tests:
    image: python:3.13
    environment:
      - PYTHONPATH=src
    volumes:
      - .:/app  # This will copy all files in the current directory into the /app directory in the container
    working_dir: /app
    command: >
      bash -c "
      python -m pip install --upgrade pip &&
      python -m pip install -e '.[dev]' &&
      python -m pytest src
      "

  black:
    image: python:3.13
    volumes:
      - .:/app  # Mounting the project directory
    working_dir: /app
    command: >
      bash -c "
      python -m pip install --upgrade pip &&
      python -m pip install black &&
      python -m black -v --check src
      "

  flake8:
    image: python:3.13
    volumes:
      - .:/app  # Mounting the project directory
    working_dir: /app
    command: >
      bash -c "
      python -m pip install --upgrade pip &&
      python -m pip install pyproject-flake8 &&
      pflake8 -v src
      "

  isort:
    image: python:3.13
    volumes:
      - .:/app  # Mounting the project directory
    working_dir: /app
    command: >
      bash -c "
      python -m pip install --upgrade pip &&
      python -m pip install isort &&
      python -m isort --check src
      "

  mypy:
    image: python:3.13
    volumes:
      - .:/app  # Mounting the project directory
    working_dir: /app
    command: >
      bash -c "
      python -m pip install --upgrade pip &&
      python -m pip install '.[mypy]' &&
      python -m mypy src
      "

odashi

Great work!

src/latexify/test_utils.py

src/latexify/ast_utils.py

src/latexify/ast_utils_test.py

src/latexify/transformers/identifier_replacer.py

Co-authored-by: Yusuke Oda <[email protected]>

…python 3.12 - Fix CI for python 3.11.

maycuatroi · 2024-10-11T11:11:16Z

@odashi -san
I Create new function ast_function_def to handle type_params for python 3.12 and I fixed the flake8 CI issue. Please help me review and approve workflow 🙏

maycuatroi · 2024-10-12T15:49:56Z

@odashi -san. I think things look good 😄

odashi

Cool, basically everything looks good. Comments are almost based on coding conventions.

src/latexify/ast_utils.py

src/latexify/ast_utils_test.py

src/latexify/parser_test.py

Co-authored-by: Yusuke Oda <[email protected]>

maycuatroi · 2024-10-15T07:59:59Z

@odashi -san, please approve the workflow, I fixed the isort issue 😄

maycuatroi · 2024-10-16T16:19:07Z

@odashi -san, please help me review. I updated follow your comment 😃

odashi

It's almost done I think, but there are still some little comments (maybe these are the last ones)

odashi · 2024-10-17T00:29:13Z

src/latexify/ast_utils_test.py

+        (ast.Constant(value=None), True),
+        (ast.Constant(value=123), True),
+        (ast.Constant(value="baz"), True),
+        (ast.Expr(value=ast.Constant(value=456)), False),
        (ast.Global(names=["qux"]), False),
    ],
 )
 def test_is_constant_legacy(value: ast.AST, expected: bool) -> None:


It looks there exists some test cases from that only @test_utils.require_at_most(7) was removed like this. Could you check the changes entirely and remove them?

The decorator (@test_utils.require_at_most(7)) was previously used to indicate that the test case would run on Python versions >= 3.7. So, even when we were on Python 3.9, the test case was still executed. Now that we've upgraded to at least Python 3.9, the test case should still run as intended. I believe it’s best to keep the test case as it is.

require_at_most(k) requires versions equal or less than 3.k. the decorated function does nothing (skip everything) otherwise.

latexify_py/src/latexify/test_utils.py

Lines 51 to 52 in 678cd0e

if sys.version_info.minor > minor:

return

odashi · 2024-10-17T00:31:18Z

src/latexify/ast_utils.py

+    name,
+    args,
+    body,
+    decorator_list,
+    returns=None,
+    type_comment=None,
+    type_params=None,
+    lineno=None,
+    col_offset=None,
+    end_lineno=None,
+    end_col_offset=None,


please add type hints.

odashi · 2024-10-17T00:32:37Z

src/latexify/ast_utils_test.py

+        (ast.Constant(value=None), False),
+        (ast.Constant(value=123), False),
+        (ast.Constant(value="baz"), True),
+        (ast.Expr(value=ast.Constant(value=456)), False),
        (ast.Global(names=["qux"]), False),
    ],
 )
 def test_is_str_legacy(value: ast.AST, expected: bool) -> None:


this test case as well

Same with decorator @test_utils.require_at_most(7)

- Update python version to 3.12

d75e6ad

maycuatroi requested a review from odashi as a code owner October 8, 2024 12:32

odashi approved these changes Oct 8, 2024

View reviewed changes

- Update python version to 3.12

2842b03

- Improve CI libraries

- Test for python 3.13

2a79b0a

- Remove ORL python 3.8, 3.9 - Fix CI unit-test

maycuatroi changed the title ~~Pump Version python to 3.12. Allow pip install for python 3.12~~ Pump Version python to 3.12, 3.13. Allow pip install for python 3.12, 3.13 Oct 9, 2024

- update python version readme

bca27e1

odashi reviewed Oct 10, 2024

View reviewed changes

maycuatroi and others added 4 commits October 11, 2024 12:29

- remove assign exception as e

fea131d

Co-authored-by: Yusuke Oda <[email protected]>

- remove if condition for python lower than 3.8

a8db822

- remove condition because python always >= 3.9

024023f

- Create new function ast_function_def to handle type_params for …

bb4ef32

…python 3.12 - Fix CI for python 3.11.

- Remove testcase for python 3.7

e8c56ca

odashi reviewed Oct 12, 2024

View reviewed changes

src/latexify/ast_utils.py Outdated Show resolved Hide resolved

src/latexify/ast_utils.py Outdated Show resolved Hide resolved

src/latexify/ast_utils_test.py Show resolved Hide resolved

src/latexify/parser_test.py Outdated Show resolved Hide resolved

maycuatroi and others added 3 commits October 13, 2024 10:23

- change to import module

4a85faf

Co-authored-by: Yusuke Oda <[email protected]>

- Fix coding convention

45345d7

- fix isort

74f83b7

- Refactor function create_function_def

7705e3a

odashi reviewed Oct 17, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pump Version python to 3.12, 3.13. Allow pip install for python 3.12, 3.13 #210

Pump Version python to 3.12, 3.13. Allow pip install for python 3.12, 3.13 #210

maycuatroi commented Oct 8, 2024

google-cla bot commented Oct 8, 2024

maycuatroi commented Oct 8, 2024

odashi commented Oct 9, 2024

maycuatroi commented Oct 9, 2024 •

edited

Loading

odashi commented Oct 9, 2024

maycuatroi commented Oct 9, 2024

odashi left a comment

maycuatroi commented Oct 11, 2024

maycuatroi commented Oct 12, 2024

odashi left a comment

maycuatroi commented Oct 15, 2024

maycuatroi commented Oct 16, 2024

odashi left a comment •

edited

Loading

odashi Oct 17, 2024

maycuatroi Oct 23, 2024

odashi Oct 25, 2024 •

edited

Loading

odashi Oct 17, 2024

odashi Oct 17, 2024

maycuatroi Oct 23, 2024

Pump Version python to 3.12, 3.13. Allow pip install for python 3.12, 3.13 #210

Are you sure you want to change the base?

Pump Version python to 3.12, 3.13. Allow pip install for python 3.12, 3.13 #210

Conversation

maycuatroi commented Oct 8, 2024

Overview

References

google-cla bot commented Oct 8, 2024

maycuatroi commented Oct 8, 2024

odashi commented Oct 9, 2024

maycuatroi commented Oct 9, 2024 • edited Loading

odashi commented Oct 9, 2024

maycuatroi commented Oct 9, 2024

odashi left a comment

Choose a reason for hiding this comment

maycuatroi commented Oct 11, 2024

maycuatroi commented Oct 12, 2024

odashi left a comment

Choose a reason for hiding this comment

maycuatroi commented Oct 15, 2024

maycuatroi commented Oct 16, 2024

odashi left a comment • edited Loading

Choose a reason for hiding this comment

odashi Oct 17, 2024

Choose a reason for hiding this comment

maycuatroi Oct 23, 2024

Choose a reason for hiding this comment

odashi Oct 25, 2024 • edited Loading

Choose a reason for hiding this comment

odashi Oct 17, 2024

Choose a reason for hiding this comment

odashi Oct 17, 2024

Choose a reason for hiding this comment

maycuatroi Oct 23, 2024

Choose a reason for hiding this comment

maycuatroi commented Oct 9, 2024 •

edited

Loading

odashi left a comment •

edited

Loading

odashi Oct 25, 2024 •

edited

Loading